Fix file public link permissions if public upload is not enabled #32958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
requested review from
a team,
ArtificialOwl,
CarlSchwan and
blizzz
and removed request for
a team
Member
|
milestone was wrong, master is 25. |
artonge
approved these changes
Jul 26, 2022
Member
|
/rebase |
PVince81
added
4. to release
nextcloud-command
force-pushed
the
fix/noid/permission-update-allow-public-uploads
branch
from
ca48986 to
5b70820
Compare
Contributor
|
PHPUnit failure:
|
…bled Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
fix/noid/permission-update-allow-public-uploads
branch
from
5b70820 to
66d09cc
Compare
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
fix/noid/permission-update-allow-public-uploads
branch
from
66d09cc to
acc68e9
Compare
Member
Author
@artonge I duplicated this test to check this works with files and fails with folders. I also fixed the 3 other failing tests for which the share was just missing a target user and a Node. This is independent from the changes in this PR. |
Member
|
Failure unrelated |
Member
|
/backport to stable24 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When "Administration -> Share -> Public upload" admin setting is disabled:
It makes perfect sense when sharing a directory but not when sharing a file which can then only be accessed in read-only by Text, NC Office and OnlyOffice.
If this is the intended behaviour, we should at least make it very explicit in the admin settings.