Skip to content

[stable22] Fix logging data context to file #32984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
backportbot-nextcloud wants to merge 1 commit into from
Closed

[stable22] Fix logging data context to file #32984

backportbot-nextcloud wants to merge 1 commit into from

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Jun 22, 2022 •
edited by blizzz
Loading

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #32242

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 22.2.10 milestone Jun 22, 2022
@skjnldsv skjnldsv mentioned this pull request Jul 5, 2022
Merged
8 tasks
@blizzz blizzz added the 3. to review Waiting for reviews label Jul 6, 2022
@blizzz
Copy link
Member

blizzz commented Jul 6, 2022

@tcitworld incompatibilities

@blizzz blizzz added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 6, 2022
@tcitworld tcitworld force-pushed the backport/32242/stable22 branch from 3f37f74 to 217af64 Compare July 6, 2022 13:08
@tcitworld
Copy link
Member

tcitworld commented Jul 6, 2022

Fixed

@blizzz blizzz added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 7, 2022
@blizzz
Copy link
Member

blizzz commented Jul 7, 2022

PHP Parse error: syntax error, unexpected 'array' (T_ARRAY), expecting function (T_FUNCTION) or const (T_CONST) in ./tests/lib/LoggerTest.php on line 33

@blizzz blizzz added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 7, 2022
@tcitworld
Fix logging data context to file
f86fb14 
It was only logged when an exception was provided or when using
logData (which is not being much used).

We make sure the interpolated parameters are not logged.

Only tested with file write logger, but shouldn't work differently.

Crash reporters always had the context.

Signed-off-by: Thomas Citharel <[email protected]>
@tcitworld tcitworld force-pushed the backport/32242/stable22 branch from 217af64 to f86fb14 Compare July 7, 2022 10:20
@tcitworld tcitworld added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 7, 2022
@skjnldsv skjnldsv mentioned this pull request Jul 8, 2022
Merged
5 tasks
@blizzz blizzz mentioned this pull request Jul 18, 2022
Merged
@PVince81
Copy link
Member

PVince81 commented Jul 27, 2022

22 is EOL

@PVince81 PVince81 closed this Jul 27, 2022
@tcitworld tcitworld deleted the backport/32242/stable22 branch July 27, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@come-nc come-nc Awaiting requested review from come-nc

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@tcitworld tcitworld Awaiting requested review from tcitworld

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 22.2.11

Development

Successfully merging this pull request may close these issues.

5 participants

@blizzz @tcitworld @PVince81 @ChristophWurst