Skip to content

Improve local domain detection #32988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Jun 23, 2022
Merged

Improve local domain detection #32988

skjnldsv merged 1 commit into from
Jun 23, 2022

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Jun 23, 2022

Signed-off-by: Côme Chilliet [email protected]

@come-nc
Improve local domain detection
d23c7d2 
Signed-off-by: Côme Chilliet <[email protected]>
@come-nc come-nc added the 3. to review Waiting for reviews label Jun 23, 2022
@come-nc come-nc added this to the Nextcloud 25 milestone Jun 23, 2022
@come-nc come-nc requested review from a team and CarlSchwan June 23, 2022 09:46
@come-nc come-nc self-assigned this Jun 23, 2022
@come-nc come-nc requested review from ArtificialOwl and blizzz and removed request for a team June 23, 2022 09:46
@miaulalala
Copy link
Contributor

miaulalala commented Jun 23, 2022 •
edited
Loading

will this also block the specific IP ranges mentioned in the linked issue?

NVM I'm Jared 19 and I can't read

miaulalala
miaulalala approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 23, 2022
@come-nc
Copy link
Contributor Author

come-nc commented Jun 23, 2022

/backport to stable24

@come-nc
Copy link
Contributor Author

come-nc commented Jun 23, 2022

/backport to stable23

@come-nc
Copy link
Contributor Author

come-nc commented Jun 23, 2022

/backport to stable22

@skjnldsv skjnldsv merged commit 859d7fc into master Jun 23, 2022
@skjnldsv skjnldsv deleted the fix/improve-local-domain-detection branch June 23, 2022 10:50
This was referenced Jun 23, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz blizzz approved these changes

@miaulalala miaulalala miaulalala approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

Assignees

@come-nc come-nc

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

6 participants

@come-nc @miaulalala @blizzz @skjnldsv @CarlSchwan