Fix detection of firefox in ContentSecurityPolicyNonceManager #33065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reuse Request::USER_AGENT_FIREFOX, and also update the safari detection since safari < 12 is not supported anymore and we can remove a bit of code duplication Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
requested review from
ArtificialOwl,
PVince81 and
come-nc
and removed request for
a team
kesselb
approved these changes
Jun 29, 2022
kesselb
approved these changes
Jun 29, 2022
Contributor
kesselb
left a comment
kesselb
left a comment
There was a problem hiding this comment.
Thanks for taking care 👍
szaimen
added
4. to release
Member
Author
|
/backport to stable24 |
Member
Author
|
/backport to stable23 |
1 similar comment
Member
Author
|
/backport to stable23 |
This was referenced Jun 30, 2022
|
The backport to stable23 failed. Please do this backport manually. |
Contributor
|
/backport to stable22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse Request::USER_AGENT_FIREFOX, and also update the safari detection
since safari < 12 is not supported anymore and we can remove a bit of
code duplication
Thanks @fancycode for the finding
Fix #33045