[Stable23] Logging, updating status for general error in federation #33103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaulalala
added
enhancement
3. to review
miaulalala
requested review from
CarlSchwan,
PVince81,
icewind1991 and
nickvergessen
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
miaulalala
force-pushed
the
enhancement/add-logging-lo-federation
branch
from
805892f to
029899b
Compare
| $this->backend->deleteAddressBook($addressBookId); | ||
| $this->logger->info('Authorization failed, remove address book: ' . $url, ['app' => 'dav']); | ||
| throw $ex; | ||
| $this->logger->error('Authorization failed, remove address book: ' . $url, ['app' => 'dav']); |
Check notice
Code scanning / Psalm
DeprecatedMethod
| throw $ex; | ||
| $this->logger->error('Authorization failed, remove address book: ' . $url, ['app' => 'dav']); | ||
| } else { | ||
| $this->logger->error('Client exception:', ['app' => 'dav', 'exception' => $ex]); |
Check notice
Code scanning / Psalm
DeprecatedMethod
miaulalala
changed the title
miaulalala
changed the title
miaulalala
force-pushed
the
enhancement/add-logging-lo-federation
branch
from
3ba74d9 to
ad0ef93
Compare
Signed-off-by: Anna Larch <[email protected]>
miaulalala
force-pushed
the
enhancement/add-logging-lo-federation
branch
from
ad0ef93 to
11089f7
Compare
Contributor
Author
|
Drone failure is Samba (unrelated) |
come-nc
approved these changes
Jul 12, 2022
Merged
blizzz
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some more logging and logging at the appropriate level. Also, the sync status was only updated for a specific error case when the server revoked access but not on general failure. This has been added too.
Manual backport of #33104