[stable24] DAV custom props: catch Exception and rollback transaction in case #33132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
requested review from
CarlSchwan,
ChristophWurst,
miaulalala,
nickvergessen and
tcitworld
blizzz
changed the title
blizzz
force-pushed
the
backport/33090/stable24
branch
from
3bfed56 to
d8e7aac
Compare
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
- before exceptions were not caught, a started transaction might not have been finished - also resolve depractions and use IQueryBuilder Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
backport/33090/stable24
branch
from
d8e7aac to
f4fd68d
Compare
miaulalala
reviewed
Jul 6, 2022
Signed-off-by: Arthur Schiwon <[email protected]>
This was referenced Jul 6, 2022
Merged
miaulalala
approved these changes
Jul 6, 2022
nickvergessen
approved these changes
Jul 8, 2022
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Looks good, didn't test
blizzz
added
4. to release
|
The backport to stable23 failed. Please do this backport manually. |
|
The backport to stable22 failed. Please do this backport manually. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjusted backport of #33090