-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
add a setup check for 64 bit #33200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a setup check for 64 bit #33200
Conversation
|
/rebase |
Signed-off-by: szaimen <[email protected]>
84d0f43 to
cf9b108
Compare
|
@MichaIng this check will only be present on NC25 and above and is not going to be backported. |
MichaIng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. We should link the related docs section as well then. I'll add a list of known issues with 32-bit systems there.
But keep in mind that this likely leads to user reports like "Why suddenly my system is not supported anymore?"/"How can I mute the warning?" 😉.
That is why we will not backport this change |
good idea! |
But users will upgrade their Nextcloud instance and then see the warning, and at least I'd be very unhappy if the upgrade would be denied on my little RPi 2 home server 😉. But yeah, major upgrade means breaking changes/support changes are possible. |
|
Thats why we are not actively blocking the upgrade. Only showing this warning then... |
PVince81
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
in theory the check could also be added in the updater in NC < 25 close to the update button so that people get a warning before clicking "update". of course only applies for web updater, not CLI phar update or other ways |
That could be irritating since nothing changed about code-wise support but only a new warning is shown, which shouldn't be a reason to not update. Or is there a plan to stop end user support when a 32-bit system is used, also not related to the known issues with it, exactly with NC25, while keeping it with NC24? The requirements update in docs has been backported, which answers this already. |
I would rather not do this. Having the setup check is enough, imo. |
|
I'll do the link to the docs in a follow-up |
|
CI failure unrelated |
See nextcloud/documentation#9071
Signed-off-by: szaimen [email protected]