Skip to content

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented Jul 11, 2022

@szaimen szaimen added enhancement 3. to review Waiting for reviews labels Jul 11, 2022
@szaimen szaimen added this to the Nextcloud 25 milestone Jul 11, 2022
@szaimen szaimen requested review from a team, ArtificialOwl, CarlSchwan, karlitschek and skjnldsv and removed request for a team July 11, 2022 14:47
@szaimen szaimen requested a review from mejo- July 11, 2022 14:56
@szaimen
Copy link
Contributor Author

szaimen commented Jul 13, 2022

/rebase

@szaimen
Copy link
Contributor Author

szaimen commented Jul 13, 2022

@MichaIng this check will only be present on NC25 and above and is not going to be backported.

Copy link
Member

@MichaIng MichaIng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. We should link the related docs section as well then. I'll add a list of known issues with 32-bit systems there.

But keep in mind that this likely leads to user reports like "Why suddenly my system is not supported anymore?"/"How can I mute the warning?" 😉.

@szaimen
Copy link
Contributor Author

szaimen commented Jul 13, 2022

But keep in mind that this likely leads to user reports like "Why suddenly my system is not supported anymore?"/"How can I mute the warning?" 😉.

That is why we will not backport this change

@szaimen
Copy link
Contributor Author

szaimen commented Jul 13, 2022

We should link the related docs section as well then.

good idea!

@MichaIng
Copy link
Member

That is why we will not backport this change

But users will upgrade their Nextcloud instance and then see the warning, and at least I'd be very unhappy if the upgrade would be denied on my little RPi 2 home server 😉. But yeah, major upgrade means breaking changes/support changes are possible.

@szaimen
Copy link
Contributor Author

szaimen commented Jul 13, 2022

Thats why we are not actively blocking the upgrade. Only showing this warning then...

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

in theory the check could also be added in the updater in NC < 25 close to the update button so that people get a warning before clicking "update". of course only applies for web updater, not CLI phar update or other ways

@MichaIng
Copy link
Member

in theory the check could also be added in the updater in NC < 25 close to the update button so that people get a warning before clicking "update".

That could be irritating since nothing changed about code-wise support but only a new warning is shown, which shouldn't be a reason to not update.

Or is there a plan to stop end user support when a 32-bit system is used, also not related to the known issues with it, exactly with NC25, while keeping it with NC24?

The requirements update in docs has been backported, which answers this already.

@szaimen
Copy link
Contributor Author

szaimen commented Jul 13, 2022

in theory the check could also be added in the updater in NC < 25 close to the update button so that people get a warning before clicking "update". of course only applies for web updater, not CLI phar update or other ways

I would rather not do this. Having the setup check is enough, imo.

@szaimen
Copy link
Contributor Author

szaimen commented Jul 13, 2022

I'll do the link to the docs in a follow-up

@szaimen
Copy link
Contributor Author

szaimen commented Jul 13, 2022

CI failure unrelated

@szaimen szaimen merged commit 9dbcf05 into master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants