Fix listening for circle events in SetupManager #33211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, SetupManager listened for deprecated events that are no longer triggered. Instead, use the circle events that actually get triggered when adding or removing a circle or circle member. Also, these events get triggered on each instance of a globalscale setup. Fixes: #33210 Signed-off-by: Jonas <[email protected]>
mejo-
requested review from
ArtificialOwl,
CarlSchwan,
PVince81,
icewind1991 and
max-nextcloud
Member
Author
|
/backport to stable24 |
ArtificialOwl
approved these changes
Jul 12, 2022
Member
|
code looks good |
CarlSchwan
approved these changes
Jul 12, 2022
PVince81
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, SetupManager listened for deprecated events that are no longer
triggered. Instead, use the circle events that actually get triggered
when adding or removing a circle or circle member. Also, these events
get triggered on each instance of a globalscale setup.
Fixes: #33210
Signed-off-by: Jonas [email protected]