-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Remake Twitter handle saving with Vue and modularize account property components #33217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
apps/settings/src/components/PersonalInfo/TwitterSection/TwitterSection.vue
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
64584ef to
a70eb01
Compare
0219f8b to
a556c67
Compare
a70eb01 to
ae18cdd
Compare
1bb7323 to
f644707
Compare
|
Keeping as draft pending merge of |
4dbe41e to
6cf836a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
ae18cdd to
3430808
Compare
edbce9e to
77f73f8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
artonge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup :)
apps/settings/src/components/PersonalInfo/shared/AccountPropertyInput.vue
Outdated
Show resolved
Hide resolved
apps/settings/src/components/PersonalInfo/shared/AccountPropertySection.vue
Outdated
Show resolved
Hide resolved
5e6458f to
db89be3
Compare
7e0cd45 to
7fd6634
Compare
7fd6634 to
df757f3
Compare
|
Rebased and review-ready |
|
@Pytal this PR seems to contain a lot more changes than just the Twitter handle, in case it's not a mistake, please adjust the PR title and description |
Title updated, description already adjusted and commits already split between modularization and Twitter section |
df757f3 to
257ab46
Compare
|
@Pytal rebase needed and also a second review |
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
257ab46 to
09f6eb5
Compare
PVince81
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Remake Twitter handle saving with Vue for accessibility purposes alongside preparations for allowing simple replacement of other account property sections with Vue
Incorporates improvements to accessibility from the https://github.com/nextcloud/nextcloud-vue library over the legacy PHP implementation
Deprecation
The
lookupServerUploadEnabledblockserver/apps/settings/templates/settings/personal/personal.info.php
Lines 208 to 235 in 16b06dd
server/lib/public/Accounts/IAccountManager.php
Lines 86 to 91 in 16b06dd
Requires