Skip to content

fix Add to your Nextcloud #33227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
szaimen wants to merge 1 commit into from
Closed

fix Add to your Nextcloud #33227

szaimen wants to merge 1 commit into from

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented Jul 13, 2022 •
edited
Loading

@szaimen szaimen added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: federation labels Jul 13, 2022
@szaimen szaimen added this to the Nextcloud 25 milestone Jul 13, 2022
@szaimen szaimen requested review from a team, PVince81, Pytal, jancborchardt, juliusknorr and skjnldsv and removed request for a team July 13, 2022 15:16
@szaimen
Copy link
Contributor Author

szaimen commented Jul 13, 2022

/backport to stable24

@szaimen
Copy link
Contributor Author

szaimen commented Jul 13, 2022

/backport to stable23

@szaimen
Copy link
Contributor Author

szaimen commented Jul 13, 2022

/backport to stable22

PVince81
PVince81 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

juliusknorr
juliusknorr reviewed Jul 13, 2022
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a change on purpose to be brandable through #25950 but from my perspective the product name of the "HanssonIT VM" should still be "Nextcloud".

@szaimen
Copy link
Contributor Author

szaimen commented Jul 13, 2022

This was a change on purpose to be brandable through #25950

cc @jancborchardt

nickvergessen
nickvergessen requested changes Jul 13, 2022
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not okay 👎🏼

@szaimen
Copy link
Contributor Author

szaimen commented Jul 13, 2022

Closing as discussed internally

@szaimen szaimen closed this Jul 13, 2022
@szaimen szaimen deleted the enh/noid/add-to-your-nextcloud branch July 13, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr left review comments

@nickvergessen nickvergessen nickvergessen requested changes

@PVince81 PVince81 PVince81 approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Pytal Pytal Awaiting requested review from Pytal

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: federation

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

6 participants

@szaimen @nickvergessen @PVince81 @juliusknorr @CarlSchwan