Skip to content

Move \OC\User\NoUserException to OCP #33239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
juliusknorr wants to merge 2 commits into from
Closed

Move \OC\User\NoUserException to OCP #33239

juliusknorr wants to merge 2 commits into from

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jul 15, 2022

The NoUserException might be useful for apps and is already used quite a lot as IRootFolder::getUserFolder may throw it.

First commit is the new class, second refactors the server usages.

@juliusknorr juliusknorr requested review from a team, CarlSchwan, PVince81, come-nc and skjnldsv and removed request for a team July 15, 2022 12:49
@juliusknorr juliusknorr added this to the Nextcloud 25 milestone Jul 15, 2022
CarlSchwan
CarlSchwan reviewed Jul 15, 2022
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2022

Possible performance regression detected

Show Output 
1 queries added

≠ /remote.php/dav/files/test with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/test.txt with 1 queries removed
  - UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/many_files with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/new_file.txt
= /remote.php/dav/files/test/new_file.txt

@CarlSchwan
Copy link
Member

CarlSchwan commented Jul 15, 2022

Possible performance regression detected
Show Output

This bot is not working correctly :(

@juliusknorr juliusknorr force-pushed the techdebt/nouserexception branch from 55bffd4 to d8e6255 Compare July 18, 2022 12:59
@juliusknorr
Copy link
Member Author

juliusknorr commented Jul 18, 2022

Failures don't seem related, but re-triggered failed jobs.

This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
come-nc
come-nc reviewed Sep 1, 2022
View reviewed changes
apps/dashboard/lib/Service/BackgroundService.php
* @throws LockedException
* @throws PreConditionNotMetException
* @throws NoUserException
* @throws \OCP\User\NoUserException
Copy link
Contributor

@come-nc come-nc Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not consistent with having a use, you do not need to namespace it here

apps/user_ldap/lib/User_LDAP.php
* @param string $uid the username
* @return bool|string
* @throws NoUserException
* @throws \OCP\User\NoUserException
Copy link
Contributor

@come-nc come-nc Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

lib/private/Files/Filesystem.php
*
* @param string|IUser|null $user
* @throws \OC\User\NoUserException if the user is not available
* @throws \OCP\User\NoUserException if the user is not available
Copy link
Contributor

@come-nc come-nc Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @throws \OCP\User\NoUserException if the user is not available
* @throws NoUserException if the user is not available

lib/private/Files/Node/Root.php
* @param string $userId user ID
* @return \OCP\Files\Folder
* @throws NoUserException
* @throws \OCP\User\NoUserException
Copy link
Contributor

@come-nc come-nc Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

tests/lib/Files/FilesystemTest.php
*/
public function testLocalMountWhenUserDoesNotExist() {
$this->expectException(\OC\User\NoUserException::class);
$this->expectException(\OCP\User\NoUserException::class);
Copy link
Contributor

@come-nc come-nc Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$this->expectException(\OCP\User\NoUserException::class);
$this->expectException(NoUserException::class);

tests/lib/Files/FilesystemTest.php

public function testNullUserThrows() {
$this->expectException(\OC\User\NoUserException::class);
$this->expectException(\OCP\User\NoUserException::class);
Copy link
Contributor

@come-nc come-nc Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$this->expectException(\OCP\User\NoUserException::class);
$this->expectException(NoUserException::class);

@come-nc
Copy link
Contributor

come-nc commented Sep 1, 2022

/rebase

This was referenced Sep 6, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz removed this from the Nextcloud 25 milestone Sep 22, 2022
@blizzz blizzz added this to the Nextcloud 26 milestone Sep 22, 2022
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 23, 2022
@skjnldsv
Copy link
Member

skjnldsv commented Oct 23, 2022

Comments to address :)

@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
@blizzz blizzz mentioned this pull request May 17, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@juliusknorr
Copy link
Member Author

juliusknorr commented Jul 11, 2023

Closing as I don't see time near to properly finish this for now

@skjnldsv skjnldsv deleted the techdebt/nouserexception branch March 14, 2024 07:47
@skjnldsv skjnldsv removed this from the Nextcloud 28 milestone Aug 14, 2024
@joshtrichards joshtrichards mentioned this pull request Mar 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@come-nc come-nc come-nc left review comments

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

No one assigned

Labels

2. developing Work in progress technical debt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@juliusknorr @CarlSchwan @come-nc @skjnldsv @blizzz