Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jul 16, 2022

This allows apps that use a different id for the navigation or content to override the anchor used for the skip content/navigation buttons. Setting to null would not add the button, e.g. for cases when there is no navigation in the app.

		$response = new TemplateResponse('dashboard', 'index', [
 			'id-app-content' => '#app-dashboard',
 			'id-app-navigation' => null,
 		]);

@nickvergessen
Copy link
Member

nice :)

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 9457ec8 into master Jul 18, 2022
@PVince81 PVince81 deleted the bugfix/noid/skip-button-ids branch July 18, 2022 07:24
@nickvergessen
Copy link
Member

Should also add this to guests and public templates?

@juliusknorr
Copy link
Member Author

Did a follow up #33266, but only for the public layout as described in the PR.

@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants