Fix inaccessible login button focus styles #33272
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Pytal
commented
Jul 18, 2022
Pytal
commented
| Before | After |
|---|---|
 |
 |
 |
 |
Signed-off-by: Christopher Ng <[email protected]>
Pytal
requested review from
CarlSchwan,
PVince81,
marcoambrosini,
nickvergessen and
szaimen
Member
|
@nimishavijay is the a11y compliant? I doubt the contrast ratio is within the WCAG requirements, what do you think? |
Member
|
I'm working on updating the look of the login page #33265 This will make it way easier to have accessible focus for the buttons. |
juliusknorr
approved these changes
Jul 18, 2022
Member
Author
|
Closng in favour of #33265 |
juliusknorr
reviewed
Jul 18, 2022
| border: 2px solid var(--color-primary-hover); | ||
| background-image: linear-gradient(40deg, var(--color-primary) 0%, var(--color-primary-light) 100%); | ||
| border: 2px solid black !important; | ||
| background-color: var(--color-primary-element-light) !important; |
Member
There was a problem hiding this comment.
Suggested change
| background-color: var(--color-primary-element-light) !important; | |
| background-color: var(--color-primary-element-hover) !important; |
Should make it compliant with the contrast ratio.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.