dashboard: Fix dark theme detection #33300
Merged
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
design
szaimen
requested review from
a team,
Pytal,
artonge and
skjnldsv
and removed request for
a team
artonge
reviewed
Jul 25, 2022
susnux
force-pushed
the
fix/dashboard-dark-color-theme
branch
from
1a20222 to
01ae0ec
Compare
Contributor
|
/compile amend / |
When system default color theme is selected for theming, the enabledThemes array is empty or just contains one entry 'default', in this case the color theme has to be retrieved from the browser. Signed-off-by: Ferdinand Thiessen <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/dashboard-dark-color-theme
branch
from
01ae0ec to
800f6b3
Compare
artonge
approved these changes
Jul 26, 2022
Pytal
approved these changes
Jul 26, 2022
Contributor
|
CI failure unrelated |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #33299 but for the dashboard app.
When system default color theme is selected for theming,
the
enabledThemesarray is empty or just contains one entry 'default',in this case the color theme has to be retrieved from the browser.