Skip to content

Improve Devices & sessions settings #33428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 1 commit into from
Aug 2, 2022
Merged

Improve Devices & sessions settings #33428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Improve Devices & sessions settings 
- Add label for better accessibility
- Only allow to add app token with a name
- Align in rows

Signed-off-by: Carl Schwan <[email protected]>
  • Loading branch information
@CarlSchwan
CarlSchwan committed Aug 1, 2022
commit 256c78374f146d67a9902b3f7b4b47cd239952c9
33 changes: 27 additions & 6 deletions apps/settings/src/components/AuthTokenSetupDialogue.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,32 +20,36 @@
-->

<template>
<div v-if="!adding">
<div v-if="!adding" class="row spacing">
<!-- Port to TextField component when available -->
<input v-model="deviceName"
type="text"
:maxlength="120"
:disabled="loading"
:placeholder="t('settings', 'App name')"
@keydown.enter="submit">
<Button :disabled="loading"
<Button :disabled="loading || deviceName.length === 0"
type="primary"
@click="submit">
{{ t('settings', 'Create new app password') }}
</Button>
</div>
<div v-else>
<div v-else class="spacing">
{{ t('settings', 'Use the credentials below to configure your app or device.') }}
{{ t('settings', 'For security reasons this password will only be shown once.') }}
<div class="app-password-row">
<span class="app-password-label">{{ t('settings', 'Username') }}</span>
<label for="app-username" class="app-password-label">{{ t('settings', 'Username') }}</label>
<input :value="loginName"
id="app-username"
type="text"
class="monospaced"
readonly="readonly"
@focus="selectInput">
</div>
<div class="app-password-row">
<span class="app-password-label">{{ t('settings', 'Password') }}</span>
<label for="app-password" class="app-password-label">{{ t('settings', 'Password') }}</label>
<input ref="appPassword"
id="app-password"
:value="appPassword"
type="text"
class="monospaced"
Expand Down Expand Up @@ -180,7 +184,8 @@ export default {

<style lang="scss" scoped>
.app-password-row {
display: table-row;
display: flex;
align-items: center;

.icon {
background-size: 16px 16px;
Expand All @@ -198,6 +203,14 @@ export default {
padding-right: 1em;
text-align: right;
vertical-align: middle;
width: 100px;
}

.row input {
height: 44px !important;
padding: 7px 12px;
margin-right: 12px;
width: 200px;
}

.monospaced {
Expand All @@ -210,4 +223,12 @@ export default {
margin: 3px 3px 3px 3px;
}

.row {
display: flex;
align-items: center;
}

.spacing {
padding-top: 16px;
}
</style>
Loading