Remove broken function resetStorage from test cases #33430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
requested review from
ArtificialOwl,
icewind1991 and
juliusknorr
and removed request for
a team
juliusknorr
approved these changes
Aug 2, 2022
Merged
CarlSchwan
approved these changes
Aug 25, 2022
blizzz
approved these changes
Aug 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method resetStorage does not work as it does not say on which instance of
\OCA\Files_Sharing\SharedStorageit sets the propertyinitialized. It tries to set it on theReflectionClassinstance, which makes no sense.Spotted by PHP 8.2.
Function came from 391fab3
Signed-off-by: Côme Chilliet [email protected]