Skip to content

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Aug 3, 2022

Before:
image

After:

image

Signed-off-by: Carl Schwan <[email protected]>
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Aug 3, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone Aug 3, 2022
@CarlSchwan CarlSchwan requested review from a team and skjnldsv August 3, 2022 13:53
@CarlSchwan CarlSchwan self-assigned this Aug 3, 2022
@CarlSchwan CarlSchwan requested review from PVince81 and artonge and removed request for a team August 3, 2022 13:53
@CarlSchwan CarlSchwan changed the title First first run wizzard Fix first run wizzard Aug 3, 2022
@artonge
Copy link
Contributor

artonge commented Aug 8, 2022

What was the issue ?

@CarlSchwan
Copy link
Member Author

What was the issue ?

I added a before screenshot, the header was missing an image

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the smell of css inside php 🥲

@PVince81 PVince81 merged commit 684cc09 into master Aug 10, 2022
@PVince81 PVince81 deleted the fix/firstrunwizzard branch August 10, 2022 20:35
This was referenced Aug 11, 2022
@skjnldsv
Copy link
Member

This broke other things, the fix could have been sent to the firstrunwizard only :)

.modal-header .firstrunwizard-header {
	padding: 20px 12px;
	background-size: var(--image-background-size);
	background-position: center;
	color: var(--color-primary-text);
	text-align: center;
	background-image: var(--image-background, var(--image-background-plain, url("../../../core/img/background.svg"), linear-gradient(
40deg, #0082c9 0%, #30b6ff 100%)));
	background-color: var(--color-primary);
	.logo[data-v-10738c5b] {
		background: var(--image-logo, url("../../../core/img/logo/logo.svg")) no-repeat center;
		background-size: contain;
	}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants