Backend for reference metadata fetching #33494
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
| /** | ||
| * @copyright Copyright (c) 2022 Julius Härtl <[email protected]> | ||
| * | ||
| * @author Julius Härtl <[email protected]> | ||
| * | ||
| * @license GNU AGPL version 3 or any later version | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU Affero General Public License as | ||
| * published by the Free Software Foundation, either version 3 of the | ||
| * License, or (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU Affero General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Affero General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| namespace OC\Core\Controller; | ||
|
|
||
| use OCP\AppFramework\Http\DataResponse; | ||
| use OCP\Collaboration\Reference\IReferenceManager; | ||
| use OCP\IRequest; | ||
|
|
||
| class ReferenceApiController extends \OCP\AppFramework\OCSController { | ||
| private IReferenceManager $referenceManager; | ||
|
|
||
| public function __construct(string $appName, IRequest $request, IReferenceManager $referenceManager) { | ||
| parent::__construct($appName, $request); | ||
| $this->referenceManager = $referenceManager; | ||
| } | ||
|
|
||
| /** | ||
| * @NoAdminRequired | ||
| */ | ||
| public function extract(string $text, bool $resolve = false, int $limit = 1): DataResponse { | ||
| $references = $this->referenceManager->extractReferences($text); | ||
|
|
||
| $result = []; | ||
| $index = 0; | ||
| foreach ($references as $reference) { | ||
| if ($index++ >= $limit) { | ||
| break; | ||
| } | ||
|
|
||
| $result[$reference] = $resolve ? $this->referenceManager->resolveReference($reference) : null; | ||
| } | ||
|
|
||
| return new DataResponse([ | ||
| 'references' => $result | ||
| ]); | ||
| } | ||
|
|
||
|
|
||
| /** | ||
| * @NoAdminRequired | ||
| * | ||
| * @param string[] $references | ||
| */ | ||
| public function resolve(array $references, int $limit = 1): DataResponse { | ||
| $result = []; | ||
| $index = 0; | ||
| foreach ($references as $reference) { | ||
| if ($index++ >= $limit) { | ||
| break; | ||
| } | ||
|
|
||
| $result[$reference] = $this->referenceManager->resolveReference($reference); | ||
| } | ||
|
|
||
| return new DataResponse([ | ||
| 'references' => array_filter($result) | ||
| ]); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
| /** | ||
| * @copyright Copyright (c) 2022 Julius Härtl <[email protected]> | ||
| * | ||
| * @author Julius Härtl <[email protected]> | ||
| * | ||
| * @license GNU AGPL version 3 or any later version | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU Affero General Public License as | ||
| * published by the Free Software Foundation, either version 3 of the | ||
| * License, or (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU Affero General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Affero General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| namespace OC\Core\Controller; | ||
|
|
||
| use OCP\AppFramework\Http\Response; | ||
| use OCP\Collaboration\Reference\IReferenceManager; | ||
| use OCP\AppFramework\Controller; | ||
| use OCP\AppFramework\Http; | ||
| use OCP\AppFramework\Http\DataDownloadResponse; | ||
| use OCP\AppFramework\Http\DataResponse; | ||
| use OCP\Files\AppData\IAppDataFactory; | ||
| use OCP\Files\NotFoundException; | ||
| use OCP\Files\NotPermittedException; | ||
| use OCP\IRequest; | ||
|
|
||
| class ReferenceController extends Controller { | ||
| private IReferenceManager $referenceManager; | ||
| private IAppDataFactory $appDataFactory; | ||
|
|
||
| public function __construct(string $appName, IRequest $request, IReferenceManager $referenceManager, IAppDataFactory $appDataFactory) { | ||
| parent::__construct($appName, $request); | ||
| $this->referenceManager = $referenceManager; | ||
| $this->appDataFactory = $appDataFactory; | ||
| } | ||
|
|
||
| /** | ||
| * @PublicPage | ||
| * @NoCSRFRequired | ||
| */ | ||
| public function preview(string $referenceId): Response { | ||
| $reference = $this->referenceManager->getReferenceByCacheKey($referenceId); | ||
juliusknorr marked this conversation as resolved.
Fixed
Show fixed
Hide fixed
Member
There was a problem hiding this comment. I don't get a hit here locally so I don't have any previews. Is there something else needed to configure? Is a Redis required? Or is the method not loading the providers or something?
Member
Author
There was a problem hiding this comment. Yes, would require redis/apcu in its current state. I'd need to think how we can make this work without, as currently we have no reference from the hashed reference that is used for the preview to the original one. |
||
| if ($reference === null) { | ||
| return new DataResponse('', Http::STATUS_NOT_FOUND); | ||
| } | ||
|
|
||
| try { | ||
| $appData = $this->appDataFactory->get('core'); | ||
|
||
| $folder = $appData->getFolder('opengraph'); | ||
| $file = $folder->getFile($referenceId); | ||
| return new DataDownloadResponse($file->getContent(), $referenceId, $reference->getImageContentType()); | ||
| } catch (NotFoundException|NotPermittedException $e) { | ||
| return new DataResponse('', Http::STATUS_NOT_FOUND); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.