Skip to content

Fix duplicate ids on apps management page #33526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artonge merged 1 commit into from
Aug 17, 2022
Merged

Fix duplicate ids on apps management page #33526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix duplicate ids on apps management page 
Signed-off-by: Christopher Ng <[email protected]>
  • Loading branch information
@Pytal
Pytal committed Aug 13, 2022
commit d9f1f5a8acd6939596b0cf3f166c1b0473eccf76
2 changes: 1 addition & 1 deletion apps/settings/src/components/SvgFilterMixin.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export default {
},
},
mounted() {
this.filterId = 'invertIconApps' + Math.floor((Math.random() * 100)) + new Date().getSeconds() + new Date().getMilliseconds()
this.filterId = 'invertIconApps-' + Math.random().toString(36).substring(2)
},
}
</script>
4 changes: 2 additions & 2 deletions dist/settings-apps-view-7418.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/settings-apps-view-7418.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading