Allow to manually specify a theme to apply to a section of an app #33564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Molakvoæ <[email protected]>
skjnldsv
requested review from
PVince81,
artonge,
juliusknorr and
szaimen
and removed request for
a team
juliusknorr
approved these changes
Aug 16, 2022
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Nice 👍
That is actually quite useful as well for collabora where the dark mode is currently still not available, but we need to pass over our css variables for theming.
szaimen
approved these changes
Aug 16, 2022
Member
Author
|
One pitfall to keep in mind though: But that can be fixed on the app side by check which current theme is enabled I guess 🤔 |
34 tasks
artonge
approved these changes
Aug 17, 2022
skjnldsv
added
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow apps to add
[data-theme-dark](or whatever theme they want) to force a specific theme to apply to a section of an app.e.g, we want to force the image editor to have a dark theme, no matter what current theme the user have.
Just adding
[data-theme-dark]to the editor root element will make the entire editor using the dark theme.Peek.16-08-2022.14-49.mp4