Use user name cache in activity providers #33615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
bug
3. to review
nickvergessen
requested review from
CarlSchwan,
ChristophWurst,
miaulalala and
tcitworld
as code owners
tcitworld
reviewed
Aug 19, 2022
Member
tcitworld
left a comment
tcitworld
left a comment
There was a problem hiding this comment.
Unless you think we need to keep the protected method for classes that could extend them, but I didn't see any in all of the code here.
If so anyway, disregard all comments.
nickvergessen
force-pushed
the
perf/noid/user-displayname-cache-for-activity-providers
branch
from
1893202 to
5080732
Compare
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
perf/noid/user-displayname-cache-for-activity-providers
branch
from
5080732 to
7e11778
Compare
tcitworld
reviewed
Aug 19, 2022
CarlSchwan
approved these changes
Aug 19, 2022
tcitworld
approved these changes
Aug 19, 2022
Member
|
Samba tests errors seems unrelated. |
nickvergessen
deleted the
perf/noid/user-displayname-cache-for-activity-providers
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joas Schilling [email protected]