Skip to content

Log attempted user name on failed password reset attempts #33623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 2 commits into from
Aug 22, 2022
Merged

Log attempted user name on failed password reset attempts #33623

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61548c5
Update LostController.php
NoSleep82 Aug 19, 2022
b03aedf
Update core/Controller/LostController.php
NoSleep82 Aug 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update LostController.php 
i would be useful to know who is trying to reset the password (misspelled username or email, ex user or some sort of attack)

Signed-off-by: NoSleep82 <[email protected]>
  • Loading branch information
@NoSleep82
NoSleep82 authored Aug 19, 2022
commit 61548c520be2bfdd127f2fd20a02dfdc5845dcf7
4 changes: 2 additions & 2 deletions core/Controller/LostController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ protected function findUserByIdOrMail(string $input): IUser {
$user = $this->userManager->get($input);
if ($user instanceof IUser) {
if (!$user->isEnabled()) {
throw new ResetPasswordException('User is disabled');
throw new ResetPasswordException('User ' . $user . ' is disabled');
}

return $user;
Expand All @@ -328,6 +328,6 @@ protected function findUserByIdOrMail(string $input): IUser {
return reset($users);
}

throw new ResetPasswordException('Could not find user');
throw new ResetPasswordException('Could not find user ' . $input);
}
}