use the updated mariadb10.6 container in drone

[szaimen]

Signed-off-by: szaimen [email protected]

[szaimen]

Cc @nickvergessen @ArtificialOwl it seems like tests fail with thr latest mariadb10.6 version: ERROR 1140 (42000) at line 2: Mixing of GROUP columns (MIN(),MAX(),COUNT(),...) with no GROUP columns is illegal if there is no GROUP BY clause. What can we do to fix this?

I made it running by not adding the sql-mode command from the drone config in #33607 and #33606...

[nickvergessen]

I made it running by not adding the sql-mode command from the drone config

Tests failed, so we don't run them.... 🤕

If the query is an issue it needs to be adjusted

[szaimen]

If the query is an issue it needs to be adjusted

And where can I find this query and why does it fail only with this new mariadb10.6 version and not with an old mariadb10.6 version?

[nickvergessen]

Maybe because they fixed something in a maintenance release?

I can't even see the query nor anything as CI just died with a timeout

[szaimen]

Maybe because they fixed something in a maintenance release?

possible

I can't even see the query nor anything as CI just died with a timeout

same

[szaimen]

cc @dr-m maybe?

Are there some known issues with the latest mariadb10.6 release and

server/.drone.yml

Line 384 in 9de927c

- --sql-mode=ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION

?

[dr-m]

@szaimen I only really know the InnoDB storage engine. On a quick read of the comments on this pull request, sql_mode=ONLY_FULL_GROUP_BY is what should cause the error to be reported for such invalid SQL. https://mariadb.com/kb/en/group-by/ does not say when the default setting of that might have been changed.

[szaimen]

I only really know the InnoDB storage engine

Ah I see. Sorry for pinging you then!

On a quick read of the comments on this pull request, sql_mode=ONLY_FULL_GROUP_BY is what should cause the error to be reported for such invalid SQL. https://mariadb.com/kb/en/group-by/ does not say when the default setting of that might have been changed.

Thanks! We'll have a look!

[szaimen]

Seems like removing ONLY_FULL_GROUP_BY indeed makes it work.

@nickvergessen since this was added intentionally, how can we debug and fix this?

[nickvergessen]

Maybe the docker image itself is incompatible with the flag? I don't know. It fails outside of the nextcloud code, so should be good/easy to report to the maria docker people?

At least our tests need to run in this mode, I don't really care how it gets enabled

[szaimen]

Maybe the docker image itself is incompatible with the flag?

I'll try that out locally.

[szaimen]

Yes, this fails with the same log:

docker run -it --rm \
--name mariadb \
-e MYSQL_ROOT_PASSWORD=owncloud \
-e MYSQL_USER=oc_autotest \
-e MYSQL_PASSWORD=owncloud \
-e MYSQL_DATABASE=oc_autotest \
ghcr.io/nextcloud/continuous-integration-mariadb-10.6:latest \
--sql-mode=ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION

[szaimen]

Reported in https://jira.mariadb.org/browse/MDEV-29347

[szaimen]

Waiting for mariadb10.6.11 release which fixes the issue. https://hub.docker.com/_/mariadb/tags?page=1&name=10.6

[szaimen]

MariaDB 10.6.11 is finally out that brings the fix. So this should finally be ready for review :)

[szaimen]

/backport to stable25

[szaimen]

CI failure unrelated

[backportbot-nextcloud]

The backport to stable25 failed. Please do this backport manually.