Make it possible to load theme/<themename>/dist #33694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
commented
Aug 25, 2022
skjnldsv
approved these changes
Aug 25, 2022
CarlSchwan
force-pushed
the
fix/load-themedir-dist
branch
from
05375b6 to
dc1fa56
Compare
CarlSchwan
force-pushed
the
fix/load-themedir-dist
branch
from
dc1fa56 to
a4e865c
Compare
This fix a regression with the theming api following the change in webpack bundling introduced in 24 Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
fix/load-themedir-dist
branch
from
a4e865c to
de168b3
Compare
Member
Author
|
Tested and this is working fine |
CarlSchwan
added
4. to release
Signed-off-by: Carl Schwan <[email protected]>
Member
Author
|
/backport to stable24 |
|
The backport to stable24 failed. Please do this backport manually. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix a regression with the theming api following the change in
webpack bundling introduced in 24
Signed-off-by: Carl Schwan [email protected]