Skip to content

Improve bulk upload and add a config switch for it #33697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
come-nc merged 9 commits into from
Aug 30, 2022
Merged

Improve bulk upload and add a config switch for it #33697

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
be7082e
Add fileid and permissions to response of bulk upload
come-nc Aug 25, 2022
5ae185a
Add bulkupload.enabled configuration switch
come-nc Aug 25, 2022
e34f2c4
Call the correct functions to get BulkUpload metadata to return
come-nc Aug 29, 2022
b3cd9b5
Move Dav fileid and permissions logic into OCP\Util to be able to use…
come-nc Aug 29, 2022
d90b314
Fix OCP\Util documentation blocks
come-nc Aug 29, 2022
9874557
Fix Capabilities tests for dav application
come-nc Aug 29, 2022
7f80dcc
Flip bulkupload.enabled default value to true
come-nc Aug 29, 2022
4f3b323
Move dav utils functions to OCP\Files\DavUtil
come-nc Aug 30, 2022
30bfd5f
Add DavUtil to autoloader
come-nc Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix OCP\Util documentation blocks 
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc
come-nc committed Aug 29, 2022
commit d90b31401c412d18e29ac08f6d091d09d1fc4ce0
8 changes: 8 additions & 0 deletions lib/public/Util.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,14 +630,22 @@ public static function isFunctionEnabled(string $functionName): bool {
}

/**
* Compute the fileId to use for dav responses
*
* @param int $id Id of the file returned by FileInfo::getId
* @since 25.0.0
*/
public static function getDavFileId(int $id): string {
$instanceId = \OC_Util::getInstanceId();
$id = sprintf('%08d', $id);
return $id . $instanceId;
}

/**
* Compute the format needed for returning permissions for dav
*
* @since 25.0.0
*/
public static function getDavPermissions(\OCP\Files\FileInfo $info): string {
$p = '';
if ($info->isShared()) {
Expand Down