Skip to content

Use display name cache on getStorageInfo #33709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 1 commit into from
Dec 19, 2022
Merged

Use display name cache on getStorageInfo #33709

PVince81 merged 1 commit into from
Dec 19, 2022

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 26, 2022 •
edited
Loading

While the method result is cached, it still might save a query from time to time and is less code than before

@juliusknorr juliusknorr requested review from a team, PVince81, blizzz and skjnldsv and removed request for a team August 26, 2022 06:36
PVince81
PVince81 approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added this to the Nextcloud 25 milestone Aug 26, 2022
@juliusknorr
Copy link
Member Author

juliusknorr commented Aug 26, 2022

Will have a look at the failing tests

@juliusknorr juliusknorr force-pushed the enh/displayname-cache-getStorageInfo branch from 2a10aea to 1d26f2a Compare August 29, 2022 06:17
@juliusknorr
Copy link
Member Author

juliusknorr commented Aug 29, 2022

One more remaining:



[Mon Aug 29 06:43:51 2022] {"Exception":"Exception","Message":"Argument 1 passed to OC\\User\\Manager::getDisplayName() must be of the type string, null given, called in \/drone\/src\/lib\/private\/legacy\/OC_Helper.php on line 545 in file '\/drone\/src\/lib\/private\/User\/Manager.php' line 191","Code":0,"Trace":[{"file":"\/drone\/src\/lib\/private\/AppFramework\/App.php","line":172,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"\/drone\/src\/lib\/private\/Route\/Router.php","line":298,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"\/drone\/src\/lib\/base.php","line":1042,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"\/drone\/src\/index.php","line":36,"function":"handleRequest","class":"OC","type":"::"}],"File":"\/drone\/src\/lib\/private\/AppFramework\/Http\/Dispatcher.php","Line":165,"Previous":{"Exception":"TypeError","Message":"Argument 1 passed to OC\\User\\Manager::getDisplayName() must be of the type string, null given, called in \/drone\/src\/lib\/private\/legacy\/OC_Helper.php on line 545","Code":0,"Trace":[{"file":"\/drone\/src\/lib\/private\/legacy\/OC_Helper.php","line":545,"function":"getDisplayName","class":"OC\\User\\Manager","type":"->"},{"file":"\/drone\/src\/apps\/files\/lib\/Controller\/ViewController.php","line":155,"function":"getStorageInfo","class":"OC_Helper","type":"::"},{"file":"\/drone\/src\/apps\/files\/lib\/Controller\/ViewController.php","line":205,"function":"getStorageInfo","class":"OCA\\Files\\Controller\\ViewController","type":"->"},{"file":"\/drone\/src\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":225,"function":"index","class":"OCA\\Files\\Controller\\ViewController","type":"->"},{"file":"\/drone\/src\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":133,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"\/drone\/src\/lib\/private\/AppFramework\/App.php","line":172,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"\/drone\/src\/lib\/private\/Route\/Router.php","line":298,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"\/drone\/src\/lib\/base.php","line":1042,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"\/drone\/src\/index.php","line":36,"function":"handleRequest","class":"OC","type":"::"}],"File":"\/drone\/src\/lib\/private\/User\/Manager.php","Line":191},"CustomMessage":"--"}

This was referenced Aug 30, 2022
Merged
Merged
@blizzz blizzz mentioned this pull request Sep 9, 2022
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
@PVince81 PVince81 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 16, 2022
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@juliusknorr juliusknorr force-pushed the enh/displayname-cache-getStorageInfo branch from 1451f49 to 2f9c914 Compare October 14, 2022 09:20
@juliusknorr
Copy link
Member Author

juliusknorr commented Oct 14, 2022

/rebase

@juliusknorr juliusknorr added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 14, 2022
@nextcloud-command nextcloud-command force-pushed the enh/displayname-cache-getStorageInfo branch from 2f9c914 to 5f004d8 Compare October 14, 2022 22:18
@PVince81
Copy link
Member

PVince81 commented Dec 16, 2022

/rebase

@PVince81 PVince81 removed the 3. to review Waiting for reviews label Dec 16, 2022
@PVince81 PVince81 added the 4. to release Ready to be released and/or waiting for tests to finish label Dec 16, 2022
@juliusknorr @PVince81
Use display name cache on getStorageInfo
1746344 
Signed-off-by: Julius Härtl <[email protected]>

Adapt test to also run isolated

Signed-off-by: Julius Härtl <[email protected]>
@nextcloud-command nextcloud-command force-pushed the enh/displayname-cache-getStorageInfo branch from 5f004d8 to 1746344 Compare December 16, 2022 17:15
@PVince81 PVince81 merged commit 1bae41c into master Dec 19, 2022
@PVince81 PVince81 deleted the enh/displayname-cache-getStorageInfo branch December 19, 2022 11:07
@PVince81
Copy link
Member

PVince81 commented Dec 19, 2022

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish performance 🚀

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

5 participants

@juliusknorr @PVince81 @CarlSchwan @blizzz