Skip to content

File widget for references #33755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 3 commits into from
Mar 2, 2023
Merged

File widget for references #33755

juliusknorr merged 3 commits into from
Mar 2, 2023

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 30, 2022 •
edited
Loading

Follow up to #33494 to implement the frontend for a files widget

Screenshot 2022-08-31 at 20 16 40

@juliusknorr juliusknorr changed the base branch from master to enh/references August 30, 2022 13:19
@juliusknorr juliusknorr mentioned this pull request Aug 30, 2022
Merged
18 tasks
@juliusknorr juliusknorr force-pushed the enh/references branch 2 times, most recently from 94ee906 to 1ab6698 Compare August 31, 2022 16:03
@juliusknorr juliusknorr force-pushed the enh/reference-file branch 2 times, most recently from 8c1abbb to 72d6655 Compare August 31, 2022 18:08
Base automatically changed from enh/references to master August 31, 2022 18:12
@juliusknorr juliusknorr marked this pull request as ready for review August 31, 2022 18:17
@juliusknorr juliusknorr added enhancement 3. to review Waiting for reviews labels Aug 31, 2022
@juliusknorr juliusknorr added this to the Nextcloud 25 milestone Aug 31, 2022
@juliusknorr juliusknorr mentioned this pull request Aug 31, 2022
Merged
4 tasks
@nickvergessen nickvergessen mentioned this pull request Aug 31, 2022
Closed
@blizzz blizzz mentioned this pull request Sep 1, 2022
Merged
julien-nc
julien-nc reviewed Sep 1, 2022
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Some little remarks.

Also, how do we register a ReferenceProvider? I suppose there is an extra registerReferenceProvider to IRegistrationContext, right?

@juliusknorr
Copy link
Member Author

juliusknorr commented Sep 1, 2022

Also, how do we register a ReferenceProvider? I suppose there is an extra registerReferenceProvider to IRegistrationContext, right?

Yes :)

@juliusknorr
Copy link
Member Author

juliusknorr commented Sep 1, 2022

I've split the event out to get it in separately. #33818

julien-nc
julien-nc approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@julien-nc julien-nc mentioned this pull request Sep 2, 2022
Open
@blizzz blizzz mentioned this pull request Sep 6, 2022
Merged
@blizzz blizzz mentioned this pull request Sep 9, 2022
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@nickvergessen nickvergessen mentioned this pull request Sep 22, 2022
Closed
@PVince81 PVince81 requested a review from icewind1991 November 4, 2022 16:47
@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@juliusknorr juliusknorr requested a review from marcelklehr March 1, 2023 10:15
marcelklehr
marcelklehr approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@marcelklehr marcelklehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

julien-nc
julien-nc requested changes Mar 1, 2023
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dialog appears with padding in the picker modal:
image
I guess this can be partially solved in this implementation but would also maybe require adjustments in the picker implementation.

Also there are 2 close buttons, one from the picker, one from the dialog. We could hide the one from the dialog IMO.

@juliusknorr juliusknorr requested a review from julien-nc March 2, 2023 08:57
@julien-nc
Copy link
Member

julien-nc commented Mar 2, 2023

@juliushaertl It seems that dist/files-reference-files.js is not included in your commits.
If I compile it locally, it loads but then the widget and custom picker are not registered and I get
[link picker] files reference provider is discoverable but does not have any related search provider or custom picker component registered in the browser console log.

julien-nc
julien-nc approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@juliusknorr
Implement file reference wiget
6130f1a 
Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr
feat(filepicker): Allow to pass target for rendering the file picker …
1da4fe4 
…to different locations

Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr
chore: Bump bundles
38e4f8a 
Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr
Copy link
Member Author

juliusknorr commented Mar 2, 2023

Failures unrelated

@juliusknorr juliusknorr merged commit c76be65 into master Mar 2, 2023
@juliusknorr juliusknorr deleted the enh/reference-file branch March 2, 2023 21:15
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@juliusknorr juliusknorr mentioned this pull request Mar 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

@julien-nc julien-nc julien-nc approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

5 participants

@juliusknorr @julien-nc @marcelklehr @blizzz