Skip to content

Conversation

@ArtificialOwl
Copy link
Member

if generated from CLI, the cloudId is based on overwrite.cli.url which might contains /index.php.

This is a quick fix that will filters the result and returns cloudId with no trailing /index.php

Signed-off-by: Maxence Lange <[email protected]>
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added this to the Nextcloud 25 milestone Sep 1, 2022
@PVince81 PVince81 added the 3. to review Waiting for reviews label Sep 1, 2022
@blizzz
Copy link
Member

blizzz commented Sep 1, 2022

Hopefully does not have any external funny side effects :)

@blizzz blizzz merged commit 2020c15 into master Sep 1, 2022
@blizzz blizzz deleted the enh/noid/cloud-id-cli branch September 1, 2022 11:35
@blizzz blizzz mentioned this pull request Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants