always use the default fs owner when storing versions #33804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
juliusknorr
approved these changes
Sep 1, 2022
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Seems to do the trick and makes more sense 👍
blizzz
approved these changes
Sep 6, 2022
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
agree with Julius. Just check the Psalm feedback.
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
version-store-user
branch
from
fbd0090 to
7be5788
Compare
Member
Author
|
ci should be happy now |
icewind1991
added
4. to release
Member
|
/backport to stable24 |
Member
|
/backport to stable23 |
Member
|
/backport to stable22 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #33305
since hook paths are always relative to the "default filesystem view" we should use that uid for filesystem stuff instead of trying to get the owner for the file.