improve app settings design #33900
Merged
improve app settings design #33900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
force-pushed
the
enh/33802/improve-appsettings-design
branch
from
80c296c to
5696eaa
Compare
szaimen
added
3. to review
szaimen
requested review from
CarlSchwan,
jancborchardt,
juliusknorr and
skjnldsv
CarlSchwan
approved these changes
Sep 5, 2022
Merged
skjnldsv
approved these changes
Sep 6, 2022
Member
|
@szaimen do you have a before/after screenshot of the settings when they are collapsed? (Ideally should look the same). Regarding my concern at #33802 (comment) |
Contributor
Author
I gues it is because the scss is not compiled yet... |
Contributor
Author
|
/rebase |
nextcloud-command
force-pushed
the
enh/33802/improve-appsettings-design
branch
from
5696eaa to
0074ce1
Compare
Contributor
Author
|
/compile amend / |
szaimen
added
4. to release
Signed-off-by: szaimen <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
enh/33802/improve-appsettings-design
branch
from
0074ce1 to
6579b6c
Compare
Contributor
Author
should work now |
Contributor
Author
|
LGTM:
|
Contributor
Author
|
failing test unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #33802
This is best reviewed like this: https://github.com/nextcloud/server/pull/33900/files?diff=unified&w=1
Signed-off-by: szaimen [email protected]