[poc] remove recursive parse on shareinfo #33916
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| private function parseNode(Node $node, int $permissionMask) { | ||
| private function parseNode(Node $node, int $permissionMask, bool $recursive = true) { |
Check notice
Code scanning / Psalm
MissingReturnType
| } | ||
| return $this->parseFolder($node, $permissionMask); | ||
|
|
||
| return $this->parseFolder($node, $permissionMask, $recursive); |
Check notice
Code scanning / Psalm
ArgumentTypeCoercion
| } | ||
|
|
||
| private function parseFolder(Folder $folder, int $permissionMask) { | ||
| private function parseFolder(Folder $folder, int $permissionMask, bool $recursive = true) { |
Check notice
Code scanning / Psalm
MissingReturnType
| try { | ||
| $new = $node; | ||
| foreach (explode('/', $subPath) as $subFolder) { | ||
| $new = $new->get($subFolder); |
Check notice
Code scanning / Psalm
PossiblyUndefinedMethod
icewind1991
reviewed
Sep 6, 2022
icewind1991
reviewed
Sep 6, 2022
Member
|
In general I'm hesitant to patch up the ShareInfo since we no longer use it ourselves with #32852 |
Signed-off-by: Maxence Lange <[email protected]>
ArtificialOwl
force-pushed
the
enh/noid/lazy-shareinfo
branch
from
3fd8249 to
f55a613
Compare
| // checking all path that link to node_id set as $st | ||
| // will returns the node that fit current node full path | ||
| /** @var Node[] $subs */ | ||
| $subs = $node->getById($startAt); |
Check failure
Code scanning / Psalm
UndefinedInterfaceMethod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a concept that will avoid recurvise parsing of all folder/files of a share by link (
/shareinfo)will returns
hasChildrenif more sub folder are available, but not parsed.A second request include
&startAt=<sub_folder_idwill returns info about this sub foler within the share.