Skip to content

Conversation

@szaimen
Copy link
Contributor

@szaimen szaimen commented Sep 8, 2022

Close #33864

Before After
image image

Signed-off-by: szaimen [email protected]

@szaimen szaimen added the 2. developing Work in progress label Sep 8, 2022
@szaimen szaimen added this to the Nextcloud 25 milestone Sep 8, 2022
@szaimen szaimen requested review from a team, PVince81, Pytal, juliusknorr and skjnldsv and removed request for a team September 8, 2022 10:31
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 8, 2022
@szaimen szaimen marked this pull request as ready for review September 8, 2022 10:31
@blizzz blizzz mentioned this pull request Sep 8, 2022
@szaimen
Copy link
Contributor Author

szaimen commented Sep 8, 2022

/compile amend /

width: 16px;
height: 16px;
vertical-align: sub;
filter: var(--background-invert-if-dark);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entire set of rules should most likely be in the two-factor-auth app, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it sjould rather be fixed here as it then applies automatically to all apps. Also is there even a way for an app to overwrite this single place?

@szaimen szaimen requested a review from skjnldsv September 8, 2022 13:10
Signed-off-by: szaimen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 8, 2022
@szaimen
Copy link
Contributor Author

szaimen commented Sep 8, 2022

CI failure unrelated

@szaimen szaimen merged commit 7ef6cfc into master Sep 8, 2022
@szaimen szaimen deleted the enh/33864/fix-2FA-icons branch September 8, 2022 17:06
@blizzz blizzz mentioned this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2FA icons are not visible in dark mode

5 participants