Skip to content

Conversation

@jancborchardt
Copy link
Member

  • Set email addresses in maxcontrast color so they are not so present
  • Remove the divider lines as they do not fit our style anymore and they are not needed for narrow lists like these
  • Adjust the height so a half entry is cut off, so people immediately see that there are more entries in the list and it’s scrollable
Before After
image image

Further issues tracked there, also cc @karlitschek as discussed:

Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from the fact that this needs to be done in the scss file

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 8, 2022
@blizzz blizzz mentioned this pull request Sep 8, 2022
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address Carl's comment

@CarlSchwan CarlSchwan requested a review from szaimen September 8, 2022 16:23
@CarlSchwan CarlSchwan force-pushed the fix/contactsmenu-design branch from 0082d8e to af30e7f Compare September 8, 2022 16:24
@CarlSchwan CarlSchwan enabled auto-merge September 8, 2022 16:24
@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Sep 8, 2022
@CarlSchwan CarlSchwan disabled auto-merge September 9, 2022 06:43
@CarlSchwan CarlSchwan merged commit 0148ec3 into master Sep 9, 2022
@CarlSchwan CarlSchwan deleted the fix/contactsmenu-design branch September 9, 2022 06:44
@blizzz blizzz mentioned this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. feature: contacts menu

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants