Skip to content

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Sep 8, 2022

  • Fix too-big margins
  • Fix horizontal scrollbar (caused by margins in the text field)
  • Add some spacing between the items (4px)
  • Center items (I love flex)

image

@szaimen
Copy link
Contributor

szaimen commented Sep 8, 2022

@CarlSchwan can you post screenshots? :)

@CarlSchwan CarlSchwan linked an issue Sep 8, 2022 that may be closed by this pull request
@szaimen szaimen added this to the Nextcloud 25 milestone Sep 8, 2022
@CarlSchwan
Copy link
Member Author

@CarlSchwan can you post screenshots? :)

done :)

@szaimen
Copy link
Contributor

szaimen commented Sep 8, 2022

@CarlSchwan can you post screenshots? :)

done :)

Thx! :)

@CarlSchwan CarlSchwan requested review from a team, PVince81 and Pytal and removed request for a team September 8, 2022 13:13
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mich better, just 2 things:

  • The "Search" title is a bit too far left, should left-align with the subheadings of the categories below
  • The search modal could use some margin from the right edge of the viewport, like the other menus there (8px)

@CarlSchwan CarlSchwan force-pushed the fix/search-menu branch 2 times, most recently from 7e4760a to 58e9578 Compare September 8, 2022 15:50
- Fix too big margins
- Fix horizontal scrolbar (caused by margin in text field)
- Add some spacing between the items (4px)
- Center items (I love flex)

Signed-off-by: Carl Schwan <[email protected]>
@CarlSchwan
Copy link
Member Author

Mich better, just 2 things:

* [x]  The "Search" title is a bit too far left, should left-align with the subheadings of the categories below

* [x]  The search modal could use some margin from the right edge of the viewport, like the other menus there (8px)

Done for both and also added the margin to the notifications to keep stuff nicely consistent nextcloud/notifications#1272

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 8, 2022
@CarlSchwan CarlSchwan merged commit 984d5ee into master Sep 9, 2022
@CarlSchwan CarlSchwan deleted the fix/search-menu branch September 9, 2022 06:43
@blizzz blizzz mentioned this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search modal design issues

5 participants