Skip to content

Fix setting menu height #33992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 1 commit into from
Sep 12, 2022
Merged

Fix setting menu height #33992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix setting menu height 
- Increase max height to match page height
- Move settings 8px from the right instead of 5px to match other top
  menus
- Handle overflow of the content correctly

Signed-off-by: Carl Schwan <[email protected]>
  • Loading branch information
@CarlSchwan
CarlSchwan committed Sep 9, 2022
commit b155adbb5118b3637467fb36b0f8c0ca65c73bdb
7 changes: 4 additions & 3 deletions core/css/header.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion core/css/header.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions core/css/header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@

@mixin header-menu-height() {
min-height: calc(44px * 1.5); // show at least 1.5 entries
max-height: calc(100vh - #{variables.$header-height} * 2);
max-height: calc(100vh - #{variables.$header-height} - 8px);
}

#header {
Expand All @@ -78,9 +78,10 @@
position: absolute;
max-width: 350px;
@include header-menu-height();
right: 5px; // relative to parent
right: 8px; // relative to parent
top: variables.$header-height;
margin: 0;
overflow-y: scroll;

&:not(.popovermenu) {
display: none;
Expand Down
7 changes: 4 additions & 3 deletions core/css/server.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading