Add "recent files" icon to navigation #340
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes asset pipeline issue with the auth token in personal page
Link shares always allowed deletion, however internally the permissions were stored as 7 which lacked delete permissions. This created an inconsistency in the Webdav permissions. This fix makes sure we include delete permissions in the share permissions, which now become 15. In case a client is still passing 7 for legacy reasons, it gets converted automatically to 15.
When filtering the file list, if a result is on an unrendered page, make sure to call _nextPage() to prerender the pages in order to display all matching results.
When decrypting all files of a single user, the admin usually does not intend encryption to be suddenly disabled for everyone. This fix reenables encryption after decrypting for a single user. Decrypting for all users will still disable encryption globally.
check login name when authenticating via token and basic auth
Use OC.Backbone instead of Backbone directly in authtoken JS code
Remove a fed share from the local table before trying to notify the remote server
Remove ie8+9 support
Also adds support for having custom login backgrounds
AppManager has a dependency on Nc being installed
Otherwise dropping something somewhere can by mistake upload the file and make it available
The app is now enabled by default
…onnect Remove tooltip when disconnecting token
…template Collapse logs and lists with HTML5 support of github
we don't need to check permissions twice
Changing name of default logfile
Add mimetype for fb2-extension
Add large sidebar previews for text files
…js object from concated string.
Changed the creation of the update notification link
Change system tags icon from a magnifying glass to a newly created tag icon. Updates both the png and it's original source SVG.
Replace the system tags tag icon svg with a version that has been optimized by the optimization script (running scour)
Added the new css class that pulls in the "recent" icon in the sidebar for @icewind's new "recent files" file listing in #292 (comment)
Add the clock icon (svg and png) discussed with Jan and Icewind for the "recent files" view.
|
@Bugsbane, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jancborchardt, @PVince81 and @MorrisJobke to be potential reviewers |
Member
|
👍 |
Member
|
@Bugsbane Could I ask you to remove the PNG. It is not needed anymore. Master will not support IE8 and 9. That are the only ones where the PNG was needed :) Beside that 👍 |
| /* icons for sidebar */ | ||
| .nav-icon-recent { | ||
| background-image: url('../img/recent.svg'); | ||
| } |
Member
There was a problem hiding this comment.
Please put the CSS in order as it is in the sidebar. :) That is, first nav-icon-files, and then nav-icon-recent.
Member
|
Closing until I helped rebasing later. See my message in the forum. |
R0Wi
pushed a commit
to R0Wi/server
that referenced
this pull request
Nov 22, 2025
Before this, PR AppAPI only supported specifying Docker images in the
following format:
* `ghcr.io/org-name/repostiry-name:tag`
* `ghcr.io/org-name/repostiry-name-{COMPUTE_DEVIСE_TYPE}:tag`
Specifying "COMPUTE_DEVIСE_TYPE" at the repository name level turned out
to be very inconvenient:
* the standard `${{ secrets.GITHUB_TOKEN }}` from actions has access
only to the repository, and to create actions for auto-publishing ExApps
docker images, you had to create a custom github token for that
* these docker images with COMPUTE_DEVIСE_TYPE were not displayed as
linked to repositories on GitHub, since adding COMPUTE_DEVIСE_TYPE
occurred at the repository name level
Therefore, **starting with AppAPI 3.0**, I propose to move
COMPUTE_DEVIСE_TYPE in the package version:
* `ghcr.io/org-name/repostiry-name:tag`
* `ghcr.io/org-name/repostiry-name:tag-{COMPUTE_DEVIСE_TYPE}`
We will leave support for the old type of COMPUTE_DEVIСE_TYPE indication
for six months, so that everyone has time to update the ExApps in which
they used COMPUTE_DEVIСE_TYPE.
Signed-off-by: Alexander Piskun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the recent files navigation icon (PNG and SVG) and the class to include it in the files app sidebar navigation.