Skip to content

Change default login background to cloud image #34000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 1 commit into from
Sep 9, 2022
Merged

Change default login background to cloud image #34000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/theming/css/settings-admin.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/theming/css/settings-admin.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
margin-bottom: 20px;
cursor: pointer;
background-color: var(--color-primary);
background-image: var(--image-background, var(--image-background-plain, url('../../../core/img/background.svg'), linear-gradient(40deg, #0082c9 0%, #30b6ff 100%)));
background-image: var(--image-background, var(--image-background-plain, url('../../../core/img/app-background.jpg'), linear-gradient(40deg, #0082c9 0%, #30b6ff 100%)));
Copy link
Member

@jancborchardt jancborchardt Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and additionally the fallback could be changed from the linear-gradient to the plain color #0082c9 (our primary)? @CarlSchwan


#theming-preview-logo {
cursor: pointer;
Expand Down
11 changes: 4 additions & 7 deletions core/css/guest.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,11 @@ body {
font-size: .875em;
line-height: 1.6em;
font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Oxygen-Sans, Ubuntu, Cantarell, 'Helvetica Neue', Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol';
color: var(--color-primary-text);
color: var(--color-text);
text-align: center;
background-color: var(--color-primary);
background-image: var(--image-background, var(--image-background-plain, url('../../../core/img/background.svg'), linear-gradient(40deg, #0082c9 0%, #30b6ff 100%)));
background-position: 50% 50%;
Copy link
Member

@jancborchardt jancborchardt Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The background-position: center center; should stay though so it’s exactly like when logged in?

background-repeat: repeat;
background-size: var(--image-background-size, 275px, contain);
background-attachment: fixed; /* fix background gradient */
background-image: var(--image-background, var(--image-background-plain, url('../../../core/img/app-background.jpg'), linear-gradient(40deg, #0082c9 0%, #30b6ff 100%)));
Copy link
Member

@jancborchardt jancborchardt Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

background-attachment: fixed;
min-height: 100%; /* fix sticky footer */
height: auto;
overflow: auto;
Expand All @@ -40,7 +37,7 @@ body {
font-weight: 600;
}
#body-login footer a {
color: var(--color-primary-text);
color: var(--color-text);
}
#body-login a:not(.button):hover,
#body-login a:not(.button):focus {
Expand Down