Skip to content

[stable23] Do not empty config.php file if reading failed for any reason #34025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szaimen merged 1 commit into from
Sep 12, 2022
Merged

[stable23] Do not empty config.php file if reading failed for any reason #34025

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Do not empty config.php file if reading failed for any reason 
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: szaimen <[email protected]>
  • Loading branch information
@szaimen
szaimen committed Sep 12, 2022
commit 5851c265a1009e88e4018f44cb1b76fa21e9cbc2
4 changes: 4 additions & 0 deletions lib/private/Config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,10 @@ private function readData() {
* @throws \Exception If no file lock can be acquired
*/
private function writeData() {
if (!is_file(\OC::$configDir.'/CAN_INSTALL') && !isset($this->cache['version'])) {
throw new HintException(sprintf('Configuration was not read or initialized correctly, not overwriting %s', $this->configFilePath));
}

// Create a php file ...
$content = "<?php\n";
$content .= '$CONFIG = ';
Expand Down