-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
merge last_activity and last_check updates #34056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7217c0c to
7d434e8
Compare
|
I've done some basic testing to ensure that both |
7d434e8 to
f012969
Compare
|
I do not have enought understanding/knowledge to approve this, sorry |
f012969 to
491f058
Compare
491f058 to
568c4b4
Compare
the debounce for updating last_activity is changed so it always updates if another field of the token has been updated, this ensures that last_check if updated even if last_activity is still in the debounce period. Signed-off-by: Robin Appelman <[email protected]>
568c4b4 to
f6d18f8
Compare
susnux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my understanding, very clean!
|
But the test needs to be adjusted @icewind1991 |
|
Wasn't this addressed with #45026? |
updateActivityhas been updated to also write any other changed field.the debounce for updating last_activity is changed so it always updates if another field of the token has been updated, this ensures that last_check if updated even if last_activity is still in the debounce period.
This is pretty much a 2nd version of #1037, which was reverted(#29682) after the
last_activityupdating changed by #29357