fix: Disable AWS SDK attempt to find shared config #34104
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
requested review from
a team,
ArtificialOwl,
ChristophWurst,
blizzz and
come-nc
and removed request for
a team
ChristophWurst
approved these changes
Sep 16, 2022
Contributor
|
Same as: #32740 |
Member
|
I merged #32740 so I think this PR can be closed |
Contributor
|
Thank you @cnbeining for your pull request 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all,
Thanks for maintaining this project!
It seems that AWS SDK shall attempt to detect
~/.aws/configwhen initialized when using S3-like Object Storage as observed here and here.This behaviour is undesired - especially when using S3-compatible endpoints - as the documentation already required users to explicity declare the endpoint when using Object Storage as Primary Storage and when using as External Storage. In a shared hosting environment the default path
~/.aws/configmay not be readable, flooding log tail with error messages.This PR shall disable AWS SDK from seeking for the shared config file thus fixing the log flooding issue.
Other fixes are possible - e.g., exposing this as a config argument - but the marginal benefit seems to be limited: we can further discuss alternative approaches in this PR.
Thanks,