Do not store generated mysql password if it was not used

[juliusknorr]

Make sure that we do not store and use the generated password if it wasn't used for user creation in cases where there is a dbpass already preconfigured

https://github.com/nextcloud/server/blob/bugfix/noid/db-password-install/lib/private/Setup/MySQL.php#L158-L159

[solracsf]

Does this fix #34123?

[Sephtex]

Does this fix #34123?

I suppose so, in NC24 I have commented out the line

$this->dbPassword = str_shuffle($password);

To bypass the reset of the password, but it seems the fix from this PR would fix it as well.

Maybe if someone can confirm? And maybe this could be backported to NC24 as well so I can avoid patching the source, and @Ma27 who created #34123 as well.

Since #30130, it is causing an issue, as config_is_read_only can't be set to true anymore when running the setup, especially when doing the next order:

• create a DB user for nextcloud (if not exists)
• installing nextcloud (DB password gets reset)

[szaimen]

/backport to stable25

[szaimen]

/backport to stable24