Skip to content

Fixing missing theming variables #34210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 3 commits into from
Sep 24, 2022
Merged

Fixing missing theming variables #34210

skjnldsv merged 3 commits into from
Sep 24, 2022

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 23, 2022 •
edited
Loading

fix nextcloud-libraries/nextcloud-vue#3249

Element primary is based on mainBackground, so it needs to be re-calculated for the dark theme too

Before After
image image

Here is a diff between the two highcontrast themes for easier review
image

@skjnldsv skjnldsv added design Design, UI, UX, etc. 3. to review Waiting for reviews labels Sep 23, 2022
@skjnldsv skjnldsv added this to the Nextcloud 25 milestone Sep 23, 2022
@skjnldsv skjnldsv requested review from a team and nickvergessen September 23, 2022 08:27
@skjnldsv skjnldsv self-assigned this Sep 23, 2022
@skjnldsv skjnldsv requested review from PVince81, artonge and szaimen and removed request for a team September 23, 2022 08:27
nickvergessen
nickvergessen approved these changes Sep 23, 2022
View reviewed changes
@szaimen
Copy link
Contributor

szaimen commented Sep 23, 2022

@skjnldsv do we need to do this for HighContrastDark as well?

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 23, 2022

@skjnldsv do we need to do this for HighContrastDark as well?

Should not as the HighContrastDarkTheme is extending from DarkTheme

skjnldsv
skjnldsv commented Sep 23, 2022
View reviewed changes
ChristophWurst
ChristophWurst approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐘

@skjnldsv skjnldsv changed the title Fixing dark primary element variables Fixing missing theming variables Sep 23, 2022
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 23, 2022

/backport to stable25

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 23, 2022
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 23, 2022 •
edited
Loading

@skjnldsv do we need to do this for HighContrastDark as well?

Hum, actually yes, we should because the background and text changes slightly
EDIT: done, found a few other issues

@skjnldsv skjnldsv force-pushed the fix/theming branch 3 times, most recently from b587901 to 5201a38 Compare September 23, 2022 13:43
nickvergessen
nickvergessen reviewed Sep 23, 2022
View reviewed changes
@skjnldsv skjnldsv merged commit b891215 into master Sep 24, 2022
@skjnldsv skjnldsv deleted the fix/theming branch September 24, 2022 05:35
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 24, 2022
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@artonge artonge Awaiting requested review from artonge

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc.

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

Highlighted counter is broken on dark mode

6 participants

@skjnldsv @szaimen @nickvergessen @ChristophWurst @blizzz