Skip to content

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Sep 27, 2022

Add presets for #33925

@Pytal Pytal added design Design, UI, UX, etc. 3. to review Waiting for reviews feature: theming labels Sep 27, 2022
@Pytal Pytal added this to the Nextcloud 25 milestone Sep 27, 2022
@Pytal Pytal requested review from a team and jancborchardt September 27, 2022 01:03
@Pytal Pytal self-assigned this Sep 27, 2022
@Pytal Pytal requested review from PVince81, skjnldsv and szaimen and removed request for a team September 27, 2022 01:03
@blizzz blizzz mentioned this pull request Sep 27, 2022
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 27, 2022
@blizzz
Copy link
Member

blizzz commented Sep 27, 2022

master is 26, please trigger backport if necessary.

@PVince81
Copy link
Member

/backport to stable25

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about custom backgrounds?

@skjnldsv
Copy link
Member

what about custom backgrounds?

Let's split things :)

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and the colors do not seem to get applied. am I doing something wrong or is the logic not in place, yet?

@skjnldsv
Copy link
Member

I tested this and the colors do not seem to get applied. am I doing something wrong or is the logic not in place, yet?

Seems liek the logic is not here yet

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 27, 2022
@Pytal
Copy link
Member Author

Pytal commented Sep 27, 2022

I tested this and the colors do not seem to get applied. am I doing something wrong or is the logic not in place, yet?

Was meant to be a micro PR for quick approval with the logic being added separately :)

@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 27, 2022
@Pytal Pytal requested a review from skjnldsv September 27, 2022 16:04
@Pytal Pytal requested a review from szaimen September 27, 2022 16:04
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was meant to be a micro PR for quick approval with the logic being added separately :)

Ah, sorry, I didn't thought you would split that much! 🙈

@szaimen
Copy link
Contributor

szaimen commented Sep 27, 2022

I tested this and the colors do not seem to get applied. am I doing something wrong or is the logic not in place, yet?

Was meant to be a micro PR for quick approval with the logic being added separately :)

@Pytal I fear ai cannot check if the colors match and look good without the logic in place...

@Pytal
Copy link
Member Author

Pytal commented Sep 27, 2022

@Pytal I fear ai cannot check if the colors match and look good without the logic in place...

Pre-checked by @jancborchardt which is better than AI ;)

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘 then ;)

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 27, 2022
@Pytal Pytal merged commit 657f2e8 into master Sep 27, 2022
@Pytal Pytal deleted the enh/shipped-background-primary-colors branch September 27, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. feature: theming

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants