Fix focussing to internal link after copy #34288
Conversation
Since a recent change to NcActions it's not possible to add a "ref" attribute on a NcAction* component. As a workaround, a ref was added on the NcActions parent component instead. Signed-off-by: Vincent Petry <[email protected]>
PVince81
requested review from
CarlSchwan,
Pytal,
artonge,
nickvergessen,
raimund-schluessler and
skjnldsv
|
/backport to stable25 |
That's a regression. This is one of the basic feature of Vue. It means we are doing something wrong 😕 |
It's a regression of nextcloud-libraries/nextcloud-vue#2911. I created a ticket with the explanation in nextcloud-libraries/nextcloud-vue#3298. |
|
/compile amend / |
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Vincent Petry <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
bugfix/34281/fix-copy-internal-link-focus
branch
from
de0264c to
42bc63f
Compare
raimund-schluessler
left a comment
raimund-schluessler
left a comment
There was a problem hiding this comment.
Code looks good, I didn't test it, though.
|
I created nextcloud-libraries/nextcloud-vue#3299 which helps to address this problem. However, even with a fix of nextcloud/vue, server would still need adjustments, since we use a render function now, which means the |
|
master is 26, please trigger backport if necessary |
Since a recent change to NcActions it's not possible to add a "ref" attribute on a NcAction* component.
As a workaround, a ref was added on the NcActions parent component instead.
Fixes #34281