Use color preset of shipped background as primary color #34298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
added
design
Pytal
requested review from
PVince81 and
artonge
and removed request for
a team
This was referenced Sep 28, 2022
Pytal
commented
Sep 28, 2022
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Merged
Member
|
master is still 26, please trigger a backport if necessary |
Member
|
Also CI is unhappy |
Contributor
|
/backport to stable25 |
Contributor
|
Conflicts |
szaimen
added
2. developing
Pytal
force-pushed
the
enh/shipped-background-colors
branch
from
d2d0bee to
e4f7c7f
Compare
szaimen
requested changes
Sep 28, 2022
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
seems to work mostly but there seem to be some bug to happen when you change your personal theming and visit the admin theming. the primary color is then set to the one of the personal color although it should still be the default Nextcloud color IIRC
See
Pytal
force-pushed
the
enh/shipped-background-colors
branch
from
e4f7c7f to
317e366
Compare
Pytal
added
3. to review
st3iny
approved these changes
Oct 1, 2022
Member
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
Very nice!
Idea for a followup: Make it work with custom images too.
Contributor
|
@Pytal Please fix the tests, if green we green we can merge |
szaimen
added
2. developing
jancborchardt
approved these changes
Oct 3, 2022
Member
|
/rebase |
Member
|
looks like it needs CI fixes nevertheless |
nextcloud-command
force-pushed
the
enh/shipped-background-colors
branch
from
9225d01 to
c6f98e2
Compare
Contributor
|
@Pytal can you please fix the CI? |
Pytal
force-pushed
the
enh/shipped-background-colors
branch
2 times, most recently
from
4d75170 to
59914f3
Compare
Pytal
added
4. to release
Contributor
|
Only one test to go! |
Pytal
force-pushed
the
enh/shipped-background-colors
branch
from
59914f3 to
eb527ea
Compare
Signed-off-by: Christopher Ng <[email protected]>
…r primary Signed-off-by: Christopher Ng <[email protected]>
Pytal
force-pushed
the
enh/shipped-background-colors
branch
from
eb527ea to
7044191
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brand color
#0082c9is preserved for backgrounds while#00639ais used as--color-primaryfor improved accessibility