unbundle files_videoplayer and clean up a little #34313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
requested review from
ArtificialOwl,
CarlSchwan,
PVince81,
skjnldsv and
szaimen
Member
Author
|
/backport to stable25 |
Pytal
approved these changes
Sep 28, 2022
skjnldsv
approved these changes
Sep 28, 2022
Member
|
Lint / php-cs check (pull_request) Failing after 55s |
Member
Author
how dare it … but, yes, let's save the empty line 👍 |
blizzz
force-pushed
the
fix/34203/rm_videoplayer
branch
from
bd87cf0 to
eff7fcf
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
fix/34203/rm_videoplayer
branch
from
eff7fcf to
4aaa459
Compare
szaimen
added
4. to release
skjnldsv
approved these changes
Sep 29, 2022
Contributor
|
CI failure unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributes to #34203