Skip to content

Reference url can always fallback to the link itself #34353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julien-nc merged 1 commit into from
Sep 30, 2022
Merged

Reference url can always fallback to the link itself #34353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
reference url can always fallback to the link itself 
Signed-off-by: Julien Veyssier <[email protected]>
  • Loading branch information
Julien Veyssier committed Sep 30, 2022
commit eff783797a5271a4097cce12639408b647c9151b
2 changes: 1 addition & 1 deletion lib/public/Collaboration/Reference/IReference.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public function setUrl(?string $url): void;
/**
* @since 25.0.0
*/
public function getUrl(): ?string;
public function getUrl(): string;

/**
* Set the reference specific rich object representation
Expand Down
4 changes: 2 additions & 2 deletions lib/public/Collaboration/Reference/Reference.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,8 @@ public function setUrl(?string $url): void {
* @inheritdoc
* @since 25.0.0
*/
public function getUrl(): ?string {
return $this->url;
public function getUrl(): string {
return $this->url ?? $this->reference;
}

/**
Expand Down