Skip to content

Dynamically adjustment for footer height #34391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RyanAveritt wants to merge 3 commits into from
Closed

Dynamically adjustment for footer height #34391

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0ded12
setup: change footer size given legal links
RyanAveritt Oct 2, 2022
2c4ffd1
dynamic footer size: conditional completed
RyanAveritt Oct 2, 2022
cb56885
Completed: Dynamically changed footer when legal links were present
RyanAveritt Oct 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/js/public/publicpage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@
*/

window.addEventListener('DOMContentLoaded', function () {

//dynamically changes footer size depending on presence of links
if(document.querySelectorAll("a.legal").length > 0) document.getElementById("body-public").querySelector('footer').style = 'height: 95px'
Copy link
Member

@skjnldsv skjnldsv Oct 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(document.querySelectorAll("a.legal").length > 0) document.getElementById("body-public").querySelector('footer').style = 'height: 95px'
if (document.querySelectorAll('a.legal').length > 0) {
document.getElementById('body-public').querySelector('footer').style = 'height: 95px'
}

Copy link
Member

@skjnldsv skjnldsv Oct 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I think @szaimen have another fix somewhere?
I'm not super sure this is the way to go 🤔


$('#body-public').find('.header-right .menutoggle').click(function() {
$(this).next('.popovermenu').toggleClass('open');
Expand Down