Skip to content

Fix missing background on upgrade #34461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 7 commits into from
Oct 13, 2022
Merged

Fix missing background on upgrade #34461

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
107a974
Fix missing background on upgrade
Pytal Oct 7, 2022
6e4a90b
Fix SQL errors
nickvergessen Oct 7, 2022
7599cbb
New code being new
nickvergessen Oct 7, 2022
7f5ef4d
Delete theming background preferences
Pytal Oct 13, 2022
b4f6329
fix querybuilder instance recuse
blizzz Oct 13, 2022
4d98128
Fix migration parameter handling
nickvergessen Oct 13, 2022
59e0710
graceful background image handling
blizzz Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix migration parameter handling 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Oct 13, 2022
commit 4d98128e9a4c170efb7ae1e5e063df14844964a2
17 changes: 8 additions & 9 deletions core/Migrations/Version25000Date20221007010957.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,23 +51,22 @@ public function __construct(IDBConnection $connection) {
*/
public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options): void {
$cleanUpQuery = $this->connection->getQueryBuilder();

$orExpr = $cleanUpQuery->expr()->orX(
$cleanUpQuery->expr()->eq('configkey', $cleanUpQuery->createNamedParameter('background')),
$cleanUpQuery->expr()->eq('configkey', $cleanUpQuery->createNamedParameter('backgroundVersion')),
);

$cleanUpQuery->delete('preferences')
->where($cleanUpQuery->expr()->eq('appid', $cleanUpQuery->createNamedParameter('theming')))
->andWhere($orExpr);
->andWhere($cleanUpQuery->expr()->orX(
$cleanUpQuery->expr()->eq('configkey', $cleanUpQuery->createNamedParameter('background')),
$cleanUpQuery->expr()->eq('configkey', $cleanUpQuery->createNamedParameter('backgroundVersion')),
));
$cleanUpQuery->executeStatement();

$updateQuery = $this->connection->getQueryBuilder();
$updateQuery->update('preferences')
->set('appid', $updateQuery->createNamedParameter('theming'))
->where($updateQuery->expr()->eq('appid', $updateQuery->createNamedParameter('dashboard')))
->andWhere($orExpr);

->andWhere($updateQuery->expr()->orX(
$updateQuery->expr()->eq('configkey', $updateQuery->createNamedParameter('background')),
$updateQuery->expr()->eq('configkey', $updateQuery->createNamedParameter('backgroundVersion')),
));
$updateQuery->executeStatement();
}
}