Skip to content

typehint migrationservice closures #34488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CarlSchwan merged 1 commit into from
Oct 10, 2022
Merged

typehint migrationservice closures #34488

CarlSchwan merged 1 commit into from
Oct 10, 2022

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Oct 9, 2022

Related to #34487

@rullzer
typehint migrationservice closures
d151999 
Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer added enhancement 3. to review Waiting for reviews labels Oct 9, 2022
@rullzer rullzer added this to the Nextcloud 26 milestone Oct 9, 2022
@CarlSchwan CarlSchwan merged commit 84f3f6e into master Oct 10, 2022
@CarlSchwan CarlSchwan deleted the typehint_closures branch October 10, 2022 11:15
@nickvergessen
Copy link
Member

nickvergessen commented Oct 12, 2022

Actually such migrations fail psalm:

Error: ….php:42:56: MoreSpecificImplementedParamType: Argument 2 of …::changeSchema has the more specific type 'Closure():OCP\DB\ISchemaWrapper', expecting 'Closure' as defined by OCP\Migration\SimpleMigrationStep::changeSchema (see https://psalm.dev/140)

So I guess we have to revert it or update the base class as well?

@nickvergessen nickvergessen mentioned this pull request Oct 12, 2022
Merged
@rullzer
Copy link
Member Author

rullzer commented Oct 12, 2022

Update the base class I guess. As the typehint is still correct.

@nickvergessen nickvergessen mentioned this pull request Oct 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer @nickvergessen @CarlSchwan